Update enduser domain and add enduser.pseudo.id
#1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
force-pushed
the
heya/add-enduser-namespace
branch
from
0a8b0e8 to
ee0970f
Compare
heyams
commented
Oct 7, 2024
lmolkova
reviewed
Oct 14, 2024
heyams
changed the title
heyams
changed the title
enduser.authentication.id
…s/semantic-conventions into heya/add-enduser-namespace
|
need some advice with this weaver error, it didn't point to any files that I have modified. it's persisting. |
if you scroll up from there, you'll see:
which looks related to this file that was deleted in your PR: |
joaopgrassi
previously requested changes
Oct 29, 2024
lmolkova
reviewed
Jan 28, 2025
trask
reviewed
Jan 29, 2025
…s/semantic-conventions into heya/add-enduser-namespace
lmolkova
reviewed
Jan 31, 2025
lmolkova
approved these changes
Jan 31, 2025
trask
reviewed
Jan 31, 2025
trask
reviewed
Jan 31, 2025
trask
approved these changes
Jan 31, 2025
MSNev
approved these changes
Jan 31, 2025
jsuereth
approved these changes
Feb 3, 2025
chalin
reviewed
Feb 4, 2025
| @@ -381,62 +380,6 @@ Examples of `peer.service` that users may specify: | |||
| - A Redis cache of auth tokens as `peer.service="AuthTokenCache"`. | |||
| - A gRPC service `rpc.service="io.opentelemetry.AuthService"` may be hosted in both a gateway, `peer.service="ExternalApiService"` and a backend, `peer.service="AuthService"`. | |||
|
|
|||
| ## General identity attributes | |||
There was a problem hiding this comment.
With this link-target gone, what should be used instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104